-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gopls/internal/highlight: DocumentHighlight for format strings #547
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 746a00e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
Message from xxx Lulu: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
This PR (HEAD: 922b6b5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
e1d3c68
to
8fc71b7
Compare
This PR (HEAD: 8fc71b7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
This PR (HEAD: 3e4a92e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
Message from Robert Findley: Patch Set 4: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-02T14:48:30Z","revision":"6829215837e2878ad9bcf8c2cd5e41864668d917"} Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
Message from Robert Findley: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
c7c9eb6
to
b5bb07b
Compare
This PR (HEAD: b5bb07b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
bf12250
to
3d7747e
Compare
This PR (HEAD: 3d7747e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
Message from Robert Findley: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
8447a0f
to
24677c6
Compare
This PR (HEAD: 24677c6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
This PR (HEAD: 1f760f1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
This PR (HEAD: d107a5e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
cfe58a6
to
b091b5f
Compare
Message from xxx Lulu: Patch Set 9: (10 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
This PR (HEAD: b091b5f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
9aadb46
to
4a54e08
Compare
This PR (HEAD: 4a54e08) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
1164416
to
76b6597
Compare
This PR (HEAD: 76b6597) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
This PR (HEAD: 0f1df25) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
This PR (HEAD: d2dd656) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
29259b8
to
d9edd77
Compare
This PR (HEAD: 192a33e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
This PR (HEAD: fa85734) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/632598. Important tips:
|
Message from xxx Lulu: Patch Set 15: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/632598. |
This CL introduces functionality for highlighting
printf-style directives and their associated variadic arguments.
Defines a general purpose function to consume a format
string with token.Pos into its constituent components,
including literals, formatting directives
(flags, width, precision, verb), and its operand. This function
can later be used to determine hover information &
possible semantic highlights.
Also fix some comments/names in CL 623156
Updates golang/go#70050