cmd/go: fail go clean command when failed to find go cache directory #70392

mneverov · 2024-11-16T13:40:48Z

Currently, if computing of the go cache directory fails it does not expose the error. Commands like go clean, exec, modindex that use go cache directory continue execution producing incorrect or no result. This patch adds an error to the return values such that it can be validated on call sites. It also introduces such validation in go clean -cache command to fail execution in case when error occurred.

Fixes #69997

gopherbot · 2024-11-16T13:45:30Z

This PR (HEAD: 69a6fb5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-16T13:52:54Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-16T15:21:58Z

Message from Max Neverov:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-16T15:21:58Z

Message from Max Neverov:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T09:28:27Z

Message from Jorropo:

Patch Set 1: Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T09:28:27Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-17T09:14:33Z","revision":"5ea8c7f7fd992cdeb1e882e9802691d9359a7a1d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T09:28:27Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Copied votes on follow-up patch sets have been updated:

LUCI-TryBot-Result-1 has been copied to patch set 2 (copy condition: "changekind:NO_CODE_CHANGE").

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T09:35:33Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-17T09:21:18Z","revision":"2aa258edd49c59e5eb3606daf68e8fe71e715ada"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T10:30:54Z

Message from Jorropo:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T10:30:54Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T10:30:55Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T15:56:25Z

Message from Max Neverov:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T18:10:24Z

Message from Jorropo:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T06:58:02Z

Message from Max Neverov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T06:58:11Z

This PR (HEAD: f43af96) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-18T11:06:41Z

Message from Jorropo:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T18:01:35Z

This PR (HEAD: e0537d1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-18T18:10:45Z

Message from Max Neverov:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T19:10:48Z

Message from Jorropo:

Patch Set 4: Code-Review+1 Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T19:10:48Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-18T19:02:38Z","revision":"4ee11b1d946106f1956ddbd9524d4e0d87db56b9"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T19:28:41Z

Message from Jorropo:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T19:28:42Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):

go on master (change 628596)

Build or test failure, click here for results.

To reproduce, try gomote repro 8730905631194697569.

Additional links for debugging:

Output for go tool dist test -json [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T19:28:42Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T19:27:35Z

Message from Sam Thanawalla:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T06:36:04Z

This PR (HEAD: 0684661) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-21T06:51:26Z

Message from Max Neverov:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T10:45:42Z

Message from Jorropo:

Patch Set 5: Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T10:54:19Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-21T10:38:11Z","revision":"98d9ceeb6dc9250466c0dae622c66eabe580c1cc"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T10:54:19Z

Message from Jorropo:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T10:54:20Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

go on master (change 628596)
tools on master (commit 9dff42e)

Build or test failure, click here for results.

To reproduce, try gomote repro 8730665570262035233.

Additional links for debugging:

Output for test golang.org/x/tools module

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T10:54:21Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T15:16:51Z

Message from Sam Thanawalla:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T16:49:50Z

This PR (HEAD: f7f708e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-21T17:06:26Z

Message from Max Neverov:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-09T15:40:51Z

Message from Sam Thanawalla:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-09T15:40:52Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-09T15:27:56Z","revision":"f8e991e74022a39ef98442521543e085f54029f8"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-09T15:49:42Z

Message from Sam Thanawalla:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-09T15:49:42Z

Message from Go LUCI:

Patch Set 6:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

go on master (change 628596)
tools on master (commit b7532e6)

Build or test failure, click here for results.

To reproduce, try gomote repro 8729016602274467041.

Additional links for debugging:

Output for test golang.org/x/tools module

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-09T15:49:43Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-09T19:35:52Z

Message from Michael Matloob:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

Currently, if computing of the go cache directory fails it does not expose the error. Commands like go clean, exec, modindex that use go cache directory continue execution producing incorrect or no result. This patch adds an error to the return values such that it can be validated on call sites. It also introduces such validation in go clean -cache command to fail execution in case when error occurred. Fixes golang#69997

gopherbot · 2024-12-10T07:06:03Z

This PR (HEAD: b866b73) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-10T07:14:10Z

Message from Max Neverov:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-10T07:14:18Z

This PR (HEAD: 35d8846) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-11T20:01:10Z

Message from Michael Matloob:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-12T06:19:28Z

Message from Max Neverov:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-12-12T06:19:38Z

This PR (HEAD: 722da12) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

mneverov added 5 commits December 10, 2024 08:03

Add test.

337aa09

Add test.

f0ba67f

Add errcheck when initializing default cache.

051dab2

Remove obsolete errcheck.

1139cca

Fix GOCACHE doc comment.

35d8846

mneverov force-pushed the fix/clean branch from b866b73 to 35d8846 Compare December 10, 2024 07:07

Fix GOCACHE doc comment again.

722da12

cmd/go: fail go clean command when failed to find go cache directory #70392

Are you sure you want to change the base?

cmd/go: fail go clean command when failed to find go cache directory #70392

Conversation

mneverov commented Nov 16, 2024 • edited Loading

gopherbot commented Nov 16, 2024

gopherbot commented Nov 16, 2024

gopherbot commented Nov 16, 2024

gopherbot commented Nov 16, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Dec 9, 2024

gopherbot commented Dec 9, 2024

gopherbot commented Dec 9, 2024

gopherbot commented Dec 9, 2024

gopherbot commented Dec 9, 2024

gopherbot commented Dec 9, 2024

gopherbot commented Dec 10, 2024

gopherbot commented Dec 10, 2024

gopherbot commented Dec 10, 2024

gopherbot commented Dec 11, 2024

gopherbot commented Dec 12, 2024

gopherbot commented Dec 12, 2024

mneverov commented Nov 16, 2024 •

edited

Loading