Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that '-source' is a required parameter #89

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

HaraldNordgren
Copy link
Contributor

@HaraldNordgren HaraldNordgren commented Aug 5, 2018

It's not clearly stated in the READMEs that -source schem://path is a required argument.

Sure, it's pretty obvious when you think about it, but I couldn't figure why it didn't work initially for me. And the error output stated only "no scheme" which is not very helpful. Seems like this is has been around for a while, so let's fix this now.

Fixes mattes/migrate#270
Fixes mattes/migrate#317

@coveralls
Copy link

coveralls commented Aug 5, 2018

Pull Request Test Coverage Report for Build 158

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.144%

Totals Coverage Status
Change from base Build 157: 0.0%
Covered Lines: 688
Relevant Lines: 1491

💛 - Coveralls

@HaraldNordgren HaraldNordgren force-pushed the improve_documentation branch 2 times, most recently from c0b1338 to 035e608 Compare August 5, 2018 21:44
@HaraldNordgren
Copy link
Contributor Author

Merge this @dhui @mattes?

@@ -78,7 +78,7 @@ Commands:
So let's say you want to run the first two migrations

```
$ migrate -database postgres://localhost:5432/database up 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use -source file://path/to/migrations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhui Updated.

@HaraldNordgren HaraldNordgren force-pushed the improve_documentation branch from 035e608 to a6eddcc Compare August 7, 2018 07:53
@dhui dhui merged commit 251bf76 into golang-migrate:master Aug 7, 2018
@HaraldNordgren HaraldNordgren deleted the improve_documentation branch August 8, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with CLI Error using the CLI
3 participants