LSP: Include braces in type import completions

[crazymerlyn]

Fixes #3498

[lpil]

Looks good! Could you add some tests and update the changelog please 🙏

[crazymerlyn]

I tried to add tests but ran into an issue. With or without my change, the tests don't generate any completions for import dep.| while working just fine for import dep.{|}. Since the behavior hasn't really changed for the second case, it's hard to add a test for it.

I did test it by installing it locally and trying it out in my editor but can't seem to replicate that behavior in the tests. Regardless of whether i use assert_completion! or assert_completion_with_prefix i can't get the completion to be generated in the case of import dep.|. Not idea why that is considering the lsp generates those completions just fine when actually using it.

[lpil]

Are you still working on this @crazymerlyn ?

[crazymerlyn]

Haven't looked at it since my last comment. Don't really have an idea for what to do next in terms of testing this change.

[Frank-III]

I tried to add tests but ran into an issue. With or without my change, the tests don't generate any completions for import dep.| while working just fine for import dep.{|}. Since the behavior hasn't really changed for the second case, it's hard to add a test for it.

I did test it by installing it locally and trying it out in my editor but can't seem to replicate that behavior in the tests. Regardless of whether i use assert_completion! or assert_completion_with_prefix i can't get the completion to be generated in the case of import dep.|. Not idea why that is considering the lsp generates those completions just fine when actually using it.

I think this happens because import dep.| results in a parse error and make the completion failed at this stage:

let module = match this.module_for_uri(&params.text_document.uri) {
                Some(m) => m,
                None => return Ok(None),
}; // can't get the module

probably need to figure out how to test this properly

[lpil]

Hello! Are you still working on this one? :)

[Frank-III]

Hi @lpil, I would like to help finish this one as the logic is completed, we just need a way to test it. since import dep.| is not a valid syntax, the current way of testing does not apply to this one, do you have suggestions on how to test it? Appreciated!

[lpil]

You would need to compile it with valid syntax, update the file in the filesystem and then ask for compilations!