Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify on stale cached records #657

Merged
merged 4 commits into from
May 26, 2023
Merged

Conversation

jonabc
Copy link
Contributor

@jonabc jonabc commented May 26, 2023

closes #656

This change adds a new configuration option stale_records_action which is used by licensed status to determine if and how to handle stored dependency metadata records that do not match any currently used dependencies.

The configuration option supports the following values:

  1. 'error': Treat stale cached records as errors. Licensed will output errors for any stale metadata files and will cause licensed status to fail.
  2. 'warn', '', or unset (default): Treat stale cached records as warnings. Licensed will output warnings for any stale metadata files but will not cause licensed status to fail.
  3. 'ignore', any other value: Ignore stale cached records. Licensed will not output any notifications about stale metadata files.

The default behavior when the value is unset is warn so that this will not cause any unexpected licensed status failures on version upgrade.

@jonabc jonabc requested a review from elrayle May 26, 2023 00:17
this value was originally "warning" but updated to "warn" while writing documentation

I missed updating the test before committing changes
@jonabc jonabc merged commit f1ad5df into master May 26, 2023
@jonabc jonabc deleted the notify-on-stale-cached-records branch May 26, 2023 16:14
@jonabc
Copy link
Contributor Author

jonabc commented May 26, 2023

Ignoring the bower failure, this is an issue with downloading the jquery package off bower and not an issue with the source itself. I've recommended removing that source entirely as most of it's usage has been replaced by npm, yarn, pnpm, deno, etc...

jonabc added a commit that referenced this pull request May 26, 2023
### Added

- Licensed status command will alert on stale cached dependency records (#657)
@jonabc jonabc mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make licensed status detect dependencies that have been removed
1 participant