Protect from crashes when using Hash#dig #450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #448 #449
This PR makes two changes to protect against failures reported
String does not have #dig method (TypeError)
peerDependencies
value to be set as"[Circular]"
. I've only been able to reproduce this on npm 6.x. This was tricky to track down as the error is being thrown internally from Hash#dig. From the line of code in licensedparent&.dig("peerDependencies", name)
, parent here is a hash butparent["peerDependencies"]
is a string. If I had to guess, I'd bet that the dig method is implemented using recursion like:python
key in the configuration file to a YAML hash, but in this case it looks like it was set to a string