fix: use cut-over-lock-timeout for instant DDL #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemvovk
requested review from
rashiq,
meiji163 and
timvaillancourt
as code owners
Addresses github#1386 by reusing the cut-over-lock-timeout from the cutover code. The lock wait timeout in the original code is actually set to double the setting, so we keep that consistent.
artemvovk
force-pushed
the
1386-instant-lock-timeout
branch
from
43303a4 to
b74154d
Compare
|
I'm wondering if we shouldn't just set the lock timeout to the minimal possible value for instant ddl? 🤔 |
|
that would be my first choice; but also having it configurable doesn't seem like the worst idea - I can update either way, delegating the decision to the reviewers. |
meiji163
approved these changes
Dec 17, 2024
|
Configurable lock timeout seems OK to me, I will merge this after fixing a bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
Related issue: #1386
Description
reusing the cut-over-lock-timeout from the cutover code. The lock wait timeout in the original code is actually set to double the setting, so we keep that consistent. Altho I do wonder why it's 2x.
there are no existing tests for the CutOverLockTimeoutSeconds currently, I can add some if that would help.
script/cibuildreturns with no formatting errors, build errors or unit test errors.