-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept archive paths when using GitHub storage #1310
Accept archive paths when using GitHub storage #1310
Conversation
Unit Test Results853 tests 853 ✅ 20s ⏱️ Results for commit 3c678c5. ♻️ This comment has been updated with latest results. |
Not sure if we want to fix it as part of this PR, but I noticed that we have some validations for when the |
co-authored-by: Arin Ghazarian <[email protected]>
Added in 5c4a21a! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes https://github.ghe.com/github/octoshift/issues/9596!
This PR makes
gh gei
work with both of the following options which end up with uploading the archive:--ghes-api-url
: When migrating from a GHES instance directly.--git-archive-path
and--metadata-archive-path
: When providing archive paths to upload prior to a migration.Here's an example of its usage (note the absence of
--ghes-api-url
):...and the resulting log output:
ThirdPartyNotices.txt
(if applicable)