Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rsa-sha2-256 workaround #1255

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Remove rsa-sha2-256 workaround #1255

merged 7 commits into from
Dec 18, 2024
+6 −122

Conversation

ArinGhazarian
Copy link
Collaborator

@ArinGhazarian ArinGhazarian commented Jun 27, 2024 •
edited
Loading

Description

This PR removes the INT tests workaround introduced in this PR as the latest SSH.NET version addressed the issue.
Additionally I upgraded SSH.NET to the latest and greatest version 2024.2.0

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

Unit Test Results

854 tests   854 ✅  20s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 052fa1a.

♻️ This comment has been updated with latest results.

@ArinGhazarian ArinGhazarian marked this pull request as ready for review December 18, 2024 21:29
@Copilot Copilot bot review requested due to automatic review settings December 18, 2024 21:29
Copilot
Copilot AI reviewed Dec 18, 2024
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • src/bbs2gh/bbs2gh.csproj: Language not supported

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

src/bbs2gh/Services/BbsSshArchiveDownloader.cs Show resolved Hide resolved
@ArinGhazarian ArinGhazarian merged commit 2b6567d into main Dec 18, 2024
28 checks passed
@ArinGhazarian ArinGhazarian deleted the remove-rsa-sha2-256-workaround-from-bbs2gh branch December 18, 2024 22:28
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 81% 72% 592 ✔
ado2gh 84% 78% 631 ✔
Octoshift 87% 76% 1345 ✔
bbs2gh 82% 76% 669 ✔
Summary 84% (7176 / 8509) 76% (1656 / 2190) 3237 ✔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@brianaj brianaj brianaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArinGhazarian @brianaj @begonaguereca