-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS]: Adding express-validator support #18252
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test case file seems to be empty?
javascript/ql/lib/semmle/javascript/frameworks/ExpressValidator.qll
Outdated
Show resolved
Hide resolved
The test output needs to be regenerated, otherwise looks good. An interesting aspect of this library is that validators like |
I will fix up the PR today and hopefully get it out the door. On the subject of the |
Just leave it in. |
I've updated the tests but I would like to add more testing before merging |
This PR adds support for
express-validator
, a middleware for Express.js that provides a way to validate incoming requests.This should reduce the false positives a number of users are seeing
Pull Request checklist
All query authors
.qhelp
. See the documentation in this repository.Internal query authors only
.ql
,.qll
, or.qhelp
files. See the documentation (internal access required).