Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group rules by type in appendix legend #1261

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mschoettle
Copy link
Contributor

Follow-up to #1258.

Changes the grouping of rules to group them by type such that patent use limitation is shown under the limitations heading.

@mschoettle
Copy link
Contributor Author

mschoettle commented Nov 26, 2024

One issue currently is that now there are two IDs #patent-use. The link in the table heading goes to the first one and highlights that one.

You can have a look here: https://opulent-journey-66577v5vp935w99-4000.app.github.dev/appendix/ Although it might become unavailable when the codespace is paused/disabled automatically.

@mlinksva
Copy link
Contributor

This is indeed simpler, but it loses muted coloring in the legend for -- "light" features.

On the issue you note, I suppose ideally both would be highlighted. And for the same license column header, the whole range of same-license variations in the legend. However, these are just nice to haves in my book.

@mschoettle mschoettle force-pushed the appendix-legend-grouping branch from 714701f to 17fbd67 Compare November 26, 2024 11:16
@mschoettle
Copy link
Contributor Author

This is indeed simpler, but it loses muted coloring in the legend for -- "light" features.

Fixed.

On the issue you note, I suppose ideally both would be highlighted. And for the same license column header, the whole
range of same-license variations in the legend. However, these are just nice to haves in my book.

That would indeed be nice. Unfortunately, it's not possible with anchors alone. Maybe with text fragments but it unfortunately cannot highlight all matches right now.

@mlinksva mlinksva merged commit 7923e10 into github:gh-pages Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants