Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ruff and pyright on pushes to main so tags can require those checks. #33

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

crimsonknave
Copy link
Collaborator

@crimsonknave crimsonknave commented Dec 17, 2024

The rules for tags are looking for Coverage, ruff, and pyright, but ruff and pyright aren't configured to run on pushes to main. They'll have passed in the PR, but the tag should be a commit reference in main, so they need to run there as well.

@Copilot Copilot bot review requested due to automatic review settings December 17, 2024 21:21
@crimsonknave crimsonknave requested a review from a team as a code owner December 17, 2024 21:21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant