Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rJOYP alias for rP1 #47

Open
Rangi42 opened this issue Dec 10, 2024 · 2 comments
Open

Missing rJOYP alias for rP1 #47

Rangi42 opened this issue Dec 10, 2024 · 2 comments

Comments

@Rangi42
Copy link
Contributor

Rangi42 commented Dec 10, 2024

Pan Docs lists $FF00 as "P1/JOYP", so I'd expect either to be usable.

@ISSOtm
Copy link
Member

ISSOtm commented Dec 11, 2024

P1 sucks as a name, because that register is used to report any player's input (and its low 4 bits indicate the active player on SGB, too!). JOYP is better at least in that regard, so I'm seconding this.

@nitro2k01
Copy link
Member

While there might be a risk for confusion, note that P doesn't stand for player, but port. Port 1 (P1) is a digital IO port with 2 outputs and 4 inputs. This is for example shown in the CPU block diagram in Nintendo's programming manual.

port p1

However, the alias rJOYP should definitely exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants