Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why "HILO" instead of "JOYPAD" for rIE? #48

Open
Rangi42 opened this issue Dec 10, 2024 · 1 comment
Open

Why "HILO" instead of "JOYPAD" for rIE? #48

Rangi42 opened this issue Dec 10, 2024 · 1 comment

Comments

@Rangi42
Copy link
Contributor

Rangi42 commented Dec 10, 2024

Pan Docs describes IE and IF as having bits for VBlank, LCD, Timer, Serial, and Joypad interrupts. hardware.inc defines constants for "STAT" instead of "LCD" (an understandable alias, one that Pan Docs uses elsewhere, though having alias constants for both would be nice), but also for "HILO" instead of "JOYPAD" (describing it as "Transition from High to Low of Pin number P10-P13"). Is there some reason why this isn't more clearly named and described as joypad-related?

@ISSOtm
Copy link
Member

ISSOtm commented Dec 11, 2024

I think calling the former “LCD STAT”, “LCD status”, or “LCD / STAT” in Pan Docs would be a good idea. hardware.inc used to call it IEF_LCDC, which is plain wrong.

Likewise, I believe that HILO is purely a historical artifact from the time where there was more than one authoritative source, and one which hasn't been fixed since because that interrupt sees near-zero use anyway. I'd like IEF_JOYP or IEF_P1 to be provided instead. (Though I don't like rP1, see #47.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants