Refactor Provider Credentials #2195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
Highlight secret row instead of open secret dialog
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
show secret data in edit mode
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
holgerkoser
reviewed
Nov 25, 2024
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
grolu
force-pushed
the
enh/refactor-secrets
branch
from
dbef902 to
5b82bcd
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
grolu
force-pushed
the
enh/refactor-secrets
branch
from
d861174 to
2e1afb0
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
grolu
force-pushed
the
enh/refactor-secrets
branch
from
2e1afb0 to
cee31b0
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
holgerkoser
reviewed
Dec 3, 2024
| @@ -48,28 +48,39 @@ export function getConfiguration () { | |||
| return getResource('/api/config') | |||
| } | |||
|
|
|||
| /* CloudProviders Secrets */ | |||
| /* Credentials */ | |||
| function invokeCloudProviderCredentialMethod (method, params) { | |||
There was a problem hiding this comment.
I think this method is sufficient
holgerkoser
reviewed
Dec 3, 2024
…into enh/refactor-secrets
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
- Improved SecretDat composable - Added tests for credential store
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
gardener-robot-ci-1
added
reviewed/ok-to-test
Removed secretData composable in favour of credential context composable
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
- Renamed secretBindingNamespace variables to bindingNamespace (preparation for credentialsbinding) - Removed $reset logic in case of CUD operations - Added missing $reset before setting store credentials
grolu
force-pushed
the
enh/refactor-secrets
branch
from
91a8b5a to
19e9497
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the backend
/cloudprovidersecretsAPISecretBinding,Secret(if own) and resolvedQuotaresourcesThis PR is also a preparation to support new CredentialsBinding resource
SecretBindingas the leading resource, access referenced secret only when we need to access the actual secret dataCredentialsBindingsin the backend and return with the list. The dashboard can then work with CredentialsBindings and SecretBindings in the frontend as they are more or less interchangeable. Only the reference to the Secret / WorkloadIdentity data is different so we need to add some kind of abstraction / transformation there.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Tests need to be adapted
Release note: