Notification improvements (last longer, allow text selection) (#281)

fregante · Mar 27, 2023 · 2874463 · 2874463
1 parent 5c6e02c
commit 2874463
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/source/background.js b/source/background.js
@@ -39,6 +39,7 @@ function handlePortListenerErrors(listener) {
 			await listener(port);
 		} catch (error) {
 			let {message} = error;
+			console.log({message});
 			if ([
 				'Failed to fetch',
 				'Load failed', // Safari

diff --git a/source/ghost-text.js b/source/ghost-text.js
@@ -270,7 +270,8 @@ function registerElements() {
 
 function getMessageDisplayTime(message) {
 	const wpm = 100; // 180 is the average words read per minute, make it slower
-	return message.split(' ').length / wpm * 60_000;
+	// Add reaction time
+	return 2000 + (message.split(' ').length / wpm * 60_000);
 }
 
 function notify(type, message, timeout = getMessageDisplayTime(message)) {
@@ -281,7 +282,14 @@ function notify(type, message, timeout = getMessageDisplayTime(message)) {
 		timeout,
 		addnCls: type === 'log' ? '' : 'ghost-text-message-error',
 	});
-	document.addEventListener('click', () => notification.remove(), {once: true});
+	document.addEventListener('click', () => {
+		// Allow selections
+		if (!window.getSelection().isCollapsed) {
+			return;
+		}
+
+		notification.remove();
+	}, {once: true});
 }
 
 function startGT() {