Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): add image support to vertexai plugin #1429

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alonsopec89
Copy link
Contributor

Add support to vertexai plugin

Checklist (if applicable):

Copy link
Collaborator

@apascal07 apascal07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests and/or a sample that uses this? I see there are many more parameters in JS like watermark, aspect ratio, etc. How come these were omitted?

@@ -169,6 +172,9 @@ func defineModel(name string, caps ai.ModelCapabilities) ai.Model {
input *ai.ModelRequest,
cb func(context.Context, *ai.ModelResponseChunk) error,
) (*ai.ModelResponse, error) {
if strings.HasPrefix(name, "imagen") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code block is auto-generated/copied from googleai.go so it's going to get overwritten. Can you figure out a way around it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just put outside of the code copied

@alonsopec89 alonsopec89 linked an issue Dec 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Go] Add Imagen support to Vertex AI plugin
2 participants