chore: test: refactor, fix and improve unmanaged miner #12143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/seal-proof-variant
branch
from
dcd9528 to
b374299
Compare
rvagg
force-pushed
the
rvagg/unmanaged-miner-improvements
branch
from
6ac252a to
91e75ec
Compare
rvagg
force-pushed
the
rvagg/seal-proof-variant
branch
from
b374299 to
fe959d1
Compare
rvagg
force-pushed
the
rvagg/unmanaged-miner-improvements
branch
from
91e75ec to
d544f77
Compare
|
@rvagg I am confused. How are these tests green without the Actors bundle containing the NI-PoRep work ? |
|
Oh okay, because we don't have any NI-PoRep tests in here. |
|
because this doesn't touch niporep in actors, that'll come in the next PR, go-state-types and ffi have all we need for now |
#12105 - which I'll rebase and squish down to a single commit + actors bundle |
|
@rvagg Please can you rebase this on master whenever you feel ready ? |
from niporep work, including some necessary bits from there but are useful in general
rvagg
force-pushed
the
rvagg/unmanaged-miner-improvements
branch
from
d544f77 to
3c7ddf9
Compare
|
All checks have completed ❌ Failed Test / Test (itest-eth_block_hash) (pull_request) |
aarshkshah1992
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently stacked on top of #12130 which should be merged first.
This is from niporep work, extracted directly out of #12105 and includes some necessary bits from there but there are also some generally useful fixes and improvements. One thing I'm working toward is multi-sector aggregates which I haven't quite got to but this refactoring makes it possible. Getting this out of #12105 makes that PR much simpler to deal with.