Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api: add an FEVM events threshold start epoch configuration option #11346

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

i-norden
Copy link
Contributor

@i-norden i-norden commented Oct 19, 2023

Related Issues

This is a QoL addition for FEVM RPC providers. As a node operator serving FEVM data it is useful to be able to define a static starting epoch at which we begin supporting returning filtered log events, e.g. at the epoch where a specific contract was deployed. This is in contrast to the existing MaxFilterHeightRange configuration parameter which defines a static range size such that as the chain progresses the supported starting epoch of this window shifts forward.

Proposed Changes

Add and wire in two new configuration parameters:

  1. FilterThresholdEpoch a uint64 which defines a specific epoch at and above which the node will support returning log events.
  2. FilterThresholdSet a bool which specifies that the node should use FilterThresholdEpoch to define the supported log events range instead of using the moving window defined by MaxFilterHeightRange.

MaxFilterHeightRange is left as the default configuration.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green (failing test appears to be some CI finickyness)

@i-norden i-norden requested a review from a team as a code owner October 19, 2023 18:52
@i-norden i-norden changed the title feat: eth api: add an events threshold start epoch configuration option feat: api: add an events threshold start epoch configuration option Oct 19, 2023
@i-norden i-norden changed the title feat: api: add an events threshold start epoch configuration option feat: api: add an FEVM events threshold start epoch configuration option Oct 19, 2023
@i-norden i-norden force-pushed the ian/events_threshold_epoch branch from c86d41a to 82f754f Compare October 19, 2023 19:26
@i-norden i-norden force-pushed the ian/events_threshold_epoch branch from 4826b7c to 87b8e0a Compare October 20, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant