refactor: move network validation to GetFullNodeAPIV1Curio #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LexLuthr
requested changes
Dec 11, 2024
build/params.go
Outdated
| NetworkTestnet = "testnet" | ||
| ) | ||
|
|
||
| func CurrentNetwork() string { |
There was a problem hiding this comment.
We don't need this function or above constants
cmd/curio/run.go
Outdated
| @@ -135,7 +138,13 @@ var runCmd = &cli.Command{ | |||
| return xerrors.Errorf("starting market RPCs: %w", err) | |||
| } | |||
|
|
|||
| err = rpc.ListenAndServe(ctx, dependencies, shutdownChan) // Monitor for shutdown. | |||
| api, closer, err := lcli.GetFullNodeAPI(cctx) | |||
There was a problem hiding this comment.
I though I already clarified that we don't need this in run in the original issue
deps/apiinfo.go
Outdated
| fullNodes = append(fullNodes, v1api) | ||
| closers = append(closers, closer) | ||
| } | ||
|
|
||
| if len(fullNodes) == 0 { | ||
| return nil, nil, xerrors.Errorf("failed to establish connection with all nodes") | ||
| return nil, nil, xerrors.Errorf("no compatible nodes found - all nodes had network mismatches or connection errors") |
There was a problem hiding this comment.
I don't think we need to change this message
LexLuthr
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Revert this file to its original form. There is still unused code there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements network validation at the API connection level to prevent mismatched network connections early in the startup process.
Changes:
build.BuildTypeString()run.gotoGetFullNodeAPIV1Curio()Fixes #340