Add last update time at /benchmarks page #198
Open
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurgunday
approved these changes
Mar 12, 2024
|
@gurgunday pipeline seems to fail on staging https://github.com/fastify/website/actions/runs/8246279348/job/22552358761?pr=198 |
|
@gurgunday do you have a chance to look into this? The error in the CD pipeline doesn't seem to be related to the changes in this PR |
|
@Eomm is more familiar than me and might be able to help faster, but I’ll try to take a look |
I tried to fix but failed, but I think there is something broken with GHA and netlify |
Eomm
changed the title
|
could you update the PR with the main branch? We fixed the deploy on staging |
mcollina
force-pushed
the
main
branch
2 times, most recently
from
3de85d2 to
8633c45
Compare
|
@marcoturi could you please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the date info of used benchmark commit inside benchmarks.json. Then use the date in the /benchmarks page
Related Issues
Addresses #176
Check List