Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reproducibility issue with GPU #781

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HendricksJudy
Copy link

Fixes #752

Add deterministic resizing method to ResizeLongestSide class and update relevant scripts and notebooks.

  • Add apply_image_deterministic method to ResizeLongestSide class in segment_anything/utils/transforms.py to ensure deterministic resizing using torch.nn.functional.interpolate with mode='nearest'.
  • Update notebooks/onnx_model_example.ipynb to use apply_image_deterministic method for resizing images and add a note about the non-reproducibility issue with GPU and potential workaround using CPU.
  • Update scripts/amg.py to use apply_image_deterministic method for resizing images.
  • Add a note in README.md about the non-reproducibility issue with GPU and potential workaround using CPU.

Fixes facebookresearch#752

Add deterministic resizing method to `ResizeLongestSide` class and update relevant scripts and notebooks.

* Add `apply_image_deterministic` method to `ResizeLongestSide` class in `segment_anything/utils/transforms.py` to ensure deterministic resizing using `torch.nn.functional.interpolate` with `mode='nearest'`.
* Update `notebooks/onnx_model_example.ipynb` to use `apply_image_deterministic` method for resizing images and add a note about the non-reproducibility issue with GPU and potential workaround using CPU.
* Update `scripts/amg.py` to use `apply_image_deterministic` method for resizing images.
* Add a note in `README.md` about the non-reproducibility issue with GPU and potential workaround using CPU.
@facebook-github-bot
Copy link

Hi @HendricksJudy!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

…method for resizing images

* Add a note about the non-reproducibility issue with GPU and potential workaround using CPU
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fine-tuning reproducibility with GPU
2 participants