-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Reverse commit range before yanking #2441
Open
Esgariot
wants to merge
2
commits into
extrawurst:master
Choose a base branch
from
Esgariot:selected-hashes-yank-reversed-range
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: Reverse commit range before yanking #2441
Esgariot
wants to merge
2
commits into
extrawurst:master
from
Esgariot:selected-hashes-yank-reversed-range
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Produce `<oldest>^..<newest>` when yanking consecutive range. Now, given consecutive marked selection, gitui's selection matches `git log`'s output in commit range.
output from
make check cargo fmt -- --check
cargo clippy --workspace --all-features
warning: the following explicit lifetimes could be elided: 'a
--> scopetime/src/lib.rs:35:6
|
35 | impl<'a> Drop for ScopeTimeLog<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
35 - impl<'a> Drop for ScopeTimeLog<'a> {
35 + impl Drop for ScopeTimeLog<'_> {
|
warning: `scopetime` (lib) generated 1 warning (run `cargo clippy --fix --lib -p scopetime` to apply 1 suggestion)
warning: [email protected]: buildname 'nightly 2024-12-03 (3a861dc)'
Checking asyncgit v0.26.3 (/home/esgariot/Development/gitui/asyncgit)
Checking filetreelist v0.5.2 (/home/esgariot/Development/gitui/filetreelist)
error: it is more idiomatic to use `Option<&T>` instead of `&Option<T>`
--> filetreelist/src/filetreeitems.rs:276:2
|
276 | / fn update_visibility(
277 | | &mut self,
278 | | prefix: &Option<PathBuf>,
| | ---------------- help: change this to: `Option<&PathBuf>`
279 | | start_idx: usize,
... |
325 | | }
326 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_option
note: the lint level is defined here
--> filetreelist/src/lib.rs:10:53
|
10 | #![deny(clippy::all, clippy::perf, clippy::nursery, clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[deny(clippy::ref_option)]` implied by `#[deny(clippy::pedantic)]`
error: could not compile `filetreelist` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: empty line after doc comment
--> asyncgit/src/sync/config.rs:73:1
|
73 | / /// get string from config
74 | |
| |_
75 | / pub fn get_config_string(
76 | | repo_path: &RepoPath,
77 | | key: &str,
78 | | ) -> Result<Option<String>> {
| |___________________________- the comment documents this function
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
note: the lint level is defined here
--> asyncgit/src/lib.rs:11:9
|
11 | #![deny(clippy::all, clippy::perf, clippy::nursery, clippy::pedantic)]
| ^^^^^^^^^^^
= note: `#[deny(clippy::empty_line_after_doc_comments)]` implied by `#[deny(clippy::all)]`
= help: if the empty line is unintentional remove it
error: the following explicit lifetimes could be elided: 'a
--> asyncgit/src/sync/logwalker.rs:13:6
|
13 | impl<'a> Eq for TimeOrderedCommit<'a> {}
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[deny(clippy::needless_lifetimes)]` implied by `#[deny(clippy::all)]`
help: elide the lifetimes
|
13 - impl<'a> Eq for TimeOrderedCommit<'a> {}
13 + impl Eq for TimeOrderedCommit<'_> {}
|
error: the following explicit lifetimes could be elided: 'a
--> asyncgit/src/sync/logwalker.rs:15:6
|
15 | impl<'a> PartialEq for TimeOrderedCommit<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
15 - impl<'a> PartialEq for TimeOrderedCommit<'a> {
15 + impl PartialEq for TimeOrderedCommit<'_> {
|
error: the following explicit lifetimes could be elided: 'a
--> asyncgit/src/sync/logwalker.rs:21:6
|
21 | impl<'a> PartialOrd for TimeOrderedCommit<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
21 - impl<'a> PartialOrd for TimeOrderedCommit<'a> {
21 + impl PartialOrd for TimeOrderedCommit<'_> {
|
error: the following explicit lifetimes could be elided: 'a
--> asyncgit/src/sync/logwalker.rs:27:6
|
27 | impl<'a> Ord for TimeOrderedCommit<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
27 - impl<'a> Ord for TimeOrderedCommit<'a> {
27 + impl Ord for TimeOrderedCommit<'_> {
|
error: could not compile `asyncgit` (lib) due to 5 previous errors
make: *** [Makefile:92: clippy] Błąd 101 lists errors unrelated to changes this pull request introduced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Produce
<oldest>^..<newest>
when yanking consecutive range.Now, given consecutive marked selection, gitui's selection matches
git log
's output in commit range.This Pull Request fixes/closes #2246.
It changes the following:
Produce
<oldest>^..<newest>
when yanking consecutive range.Now, given consecutive marked selection, gitui's selection matches
git log
's output in commit range.I followed the checklist:
make check
without errors