Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copied hash ranges are backwards #2246

Open
Desdaemon opened this issue May 24, 2024 · 0 comments · May be fixed by #2441
Open

Copied hash ranges are backwards #2246

Desdaemon opened this issue May 24, 2024 · 0 comments · May be fixed by #2441
Labels
bug Something isn't working

Comments

@Desdaemon
Copy link

Desdaemon commented May 24, 2024

Describe the bug
I've been using the hash range copy feature introduced in #1288 to do a lot of cherry-picking, a large majority of which are consecutive ranges. However I can't use the range as-is and would have to manually reverse it myself, since marks are sorted by latest first. Thank you!

EDIT(2024/06/28): I've noticed that even for non-consecutive ranges the order is reversed. If the order of marks is not depended on anything else in gitui, I think it's desirable to reverse it for ease of use.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Log screen
  2. Mark a consecutive range of commits and copy to clipboard
  3. Try to git cherry-pick with the copied range
  4. error: empty commit set passed

Expected behavior
It would be more convenient for hash ranges to be sorted from oldest to latest.

Screenshots
N/A

Context

  • OS/Distro + Version: Pop_OS 22.04
  • GitUI Version: nightly 2024-05-19
  • Rust version: 1.78.0

Additional context
N/A

@Desdaemon Desdaemon added the bug Something isn't working label May 24, 2024
@Esgariot Esgariot linked a pull request Dec 3, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant