track/trophies index returns a JSON object, not a list (#6948)

* track/trophies index returns a JSON object, not a list * update test * tests comparing JSON values
exercism · Jun 21, 2024 · 71f9024 · 71f9024
1 parent f481b04
commit 71f9024
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/app/controllers/api/tracks/trophies_controller.rb b/app/controllers/api/tracks/trophies_controller.rb
@@ -2,7 +2,7 @@ class API::Tracks::TrophiesController < API::BaseController
   def index
     track = Track.find(params[:track_slug])
 
-    render json: SerializeTrackTrophies.(track, current_user)
+    render json: { trophies: SerializeTrackTrophies.(track, current_user) }
   end
 
   def reveal

diff --git a/test/controllers/api/tracks/trophies_controller_test.rb b/test/controllers/api/tracks/trophies_controller_test.rb
@@ -4,6 +4,9 @@ class API::Tracks::TrophiesControllerTest < API::BaseTestCase
   guard_incorrect_token! :reveal_api_track_trophy_path, args: 2, method: :patch
   guard_incorrect_token! :api_track_trophies_path, args: 1, method: :get
 
+  #########
+  # Index #
+  #########
   test "index with none revealed" do
     track = create :track
     create :trophy, valid_track_slugs: [track.slug]
@@ -13,7 +16,7 @@ class API::Tracks::TrophiesControllerTest < API::BaseTestCase
     get api_track_trophies_url(track.slug), headers: @headers, as: :json
 
     assert_response :ok
-    expected = SerializeTrackTrophies.(track, User.first).to_json
+    expected = { trophies: SerializeTrackTrophies.(track, User.first) }.to_json
     assert_equal expected, response.body
   end
 
@@ -27,7 +30,7 @@ class API::Tracks::TrophiesControllerTest < API::BaseTestCase
     get api_track_trophies_url(track.slug), headers: @headers, as: :json
 
     assert_response :ok
-    expected = SerializeTrackTrophies.(track, user).to_json
+    expected = { trophies: SerializeTrackTrophies.(track, User.first) }.to_json
     assert_equal expected, response.body
   end