wneumann: add and improve tests for swift/nucleotide-count #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… strands, and strands that contain valid and invalid nucleotides (current validation test was only with all invalid characters). More importantly, I modified the tests to remove force unwrapping and to use XCTUnwrap instead. We would encourage our students to not use force unwrapping in their code, and we shouldn't use it in ours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two tests that look for corner cases that I have had students trip up on. Single nucleotide strands, and strands that contain both valid and invalid nucleotides (current validation test was only with all invalid characters).
I also modified the tests to remove force unwrapping and to use XCTAsserNonNil) instead (tried to use XCTUnwrap, but found out the infrastructure doesn't yet support XCTUnwrap). As mentors, we would encourage our students to not use force unwrapping in their code, and we shouldn't use it in ours.