-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parallel letter frequency #426
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! One small note inline
config.json
Outdated
"practices": [], | ||
"prerequisites": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to have some practices and prerequisites here!
import gleam/dict.{type Dict} | ||
import gleam/list | ||
import gleam/option.{type Option, None, Some} | ||
import gleam/otp/task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hasn't been taught yet by this point, and it's an indirect dependency so it'll emit a warning.
It would be best if the concept of an OTP task had been taught prior to having the student use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the CI build failed as I had added the OTP task to the prerequisite, although it hasn't been added yet. I've since it removed it and raised #454.
config.json
Outdated
"lists" | ||
], | ||
"prerequisites": [ | ||
"lists" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing regex, options, strings, dicts, and OTP tasks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think missed those earlier as I didn't seem them listed in the existing concepts. I've just added them and pushed.
With the dict
one, I put maps
in its place as I noticed the existing ones called it maps
instead of dict
and I assumed it would be updated as part #396. Let me know if you'd prefer me to change it to dict
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update - Nevermind, I just saw pull request #431 and decided to go ahead and update this pull request to use dicts
to match.
…el-letter-frequency
This is to match the upcoming changes in PR exercism#431.
…el-letter-frequency
…el-letter-frequency
…el-letter-frequency
Adds the parallel letter frequency for 48in24.