ledger #316
ledger #316
Conversation
|
Hello 👋 Thanks for your PR. This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed. If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track. Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum. (cc @exercism/cross-track-maintainers) |
| fn one_entry() { | ||
| let currency = Currency::USD; | ||
| let locale = Locale::en_US; | ||
| let entries = array![("2015-01-01", "Buy present", "-1000")]; |
There was a problem hiding this comment.
Let's update entry tuples into structs
| fn one_entry() { | ||
| let currency = Currency::USD; | ||
| let locale = Locale::en_US; | ||
| let entries = array![("2015-01-01", "Buy present", "-1000")]; |
There was a problem hiding this comment.
| let entries = array![("2015-01-01", "Buy present", "-1000")]; | |
| let entries = array![("2015-01-01", "Buy present", -1000)]; |
You should use signed integers for amountInCents, see canonical data.
Any particular reason you opted for treating them as ByteArray?
There was a problem hiding this comment.
I only used byteArray to make the entries consistent and mostly it will be easier to deal with positive and negative value, I will try and change it to signed integers and work around it
There was a problem hiding this comment.
@0xNeshi, I need help trying to convert i32 data type to ByteArray, Do you have any suggestion that can help implement such?
There was a problem hiding this comment.
it should be possible to simply append the i32 value:
let amount_in_cents = -1000_i32;
// ...
let row = format!("{} | {} | {}", formatted_date, format_transaction(transaction), amount_in_cents);Doesn't it work?
There was a problem hiding this comment.
According to canonical.json, the amount_in_cents is expected to be seperated with , or . based on the locale for value that are up to 5 character for example -123456 is expected to be ($1,234.56) which means I have to be able to get into individual character to determine where the , or . is to be placed and using the format! macro won't give me the opprtunity to do that.
There was a problem hiding this comment.
let y = -123456_i32;
let cents = (y % 100) * -1; // In Cairo `%` includes negative remainders, so we make it a positive number!
let main = y / 100;
let str = format!("{main}.{cents}");
println!("{str}"); // prints "-1234.56"
let str = format!("{main},{cents}");
println!("{str}"); // prints "-1234,56"There was a problem hiding this comment.
The expected data is supposed to be -1, 234.56 or -1.234,56 , the , and . that seperate the main value for readability are expected too
There was a problem hiding this comment.
You can use a similar approach to take 3-digit chunks out of a number by dividing it with 1000, and concatenate with the appropriate delimiter.
We should follow canonical data and use signed integers. It will change your existing formatting logic, but it'll probably be even more straightforward than it currently is.
Even if it's less straightforward, the idea is to solve the canonical exercise as it is using Cairo.
There was a problem hiding this comment.
You can take inspiration from Python's solution
There was a problem hiding this comment.
Thank you, I have been able to make it work with the format! macro
| let currency = Currency::USD; | ||
| let locale = Locale::en_US; | ||
| let entries = array
| let mut sep = 0; | ||
| let mut i = 0; | ||
|
|
||
| while i < date.len() { |
There was a problem hiding this comment.
You could probably separate this single while loop into 3 loops, each building it's own part of the date.
Then you wouldn't need so many if checks within
| if locale == @Locale::nl_NL { | ||
| result.append_byte(' '); | ||
| } | ||
|
|
||
| if negative && locale != @Locale::en_US { | ||
| result.append_byte('-'); | ||
| } |
There was a problem hiding this comment.
| if locale == @Locale::nl_NL { | |
| result.append_byte(' '); | |
| } | |
| if negative && locale != @Locale::en_US { | |
| result.append_byte('-'); | |
| } | |
| if locale == @Locale::nl_NL { | |
| result.append_byte(' '); | |
| if negative { | |
| result.append_byte('-'); | |
| } | |
| } |
Because: locale != @Locale::en_US is the same as locale == @Locale::nl_NL
| fn format_transaction(transaction: ByteArray) -> ByteArray { | ||
| let mut formatted = ""; | ||
|
|
||
| if transaction.len() > 22 { |
There was a problem hiding this comment.
What does 22 mean? Use a const variable with a meaningful name
| formatted += "..."; | ||
| } else { | ||
| formatted += transaction; | ||
| while formatted.len() < 25 { |
There was a problem hiding this comment.
What does 25 mean? Use a const variable with a meaningful name
Closes #196