Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change C++ .h files into .hpp files for modernisation #610

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

JustCallMeRay
Copy link

@JustCallMeRay JustCallMeRay commented Nov 30, 2024

The generally accepted assumptions are:

  • .h is the file extension for C header files
  • .hpp is the file extenstion for C++ header files

Currently all the C++ headers are marked as C header files. This makes it a little more confusing for tooling and people to understand how the code is intended to be used.

The LLVM style guide does use .h files (though doesn't say to use them) but they have comment with -*- C++ -*- at the top of every .h file for tooling, since we don't have said comments, I recommend moving to .hpp files instead.

More information is provided by Jason Turner

Copy link

cla-bot bot commented Nov 30, 2024

Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added.

Copy link

cla-bot bot commented Nov 30, 2024

Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added.

Copy link

cla-bot bot commented Nov 30, 2024

Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added.

Copy link

cla-bot bot commented Nov 30, 2024

Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added.

1 similar comment
Copy link

cla-bot bot commented Dec 1, 2024

Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added.

Copy link

cla-bot bot commented Dec 1, 2024

Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added.

Copy link

cla-bot bot commented Dec 1, 2024

Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added.

Copy link

cla-bot bot commented Dec 1, 2024

Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added.

Copy link

cla-bot bot commented Dec 1, 2024

Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added.

Copy link

cla-bot bot commented Dec 1, 2024

Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added.

@JustCallMeRay JustCallMeRay marked this pull request as ready for review December 1, 2024 19:21
@JustCallMeRay
Copy link
Author

I have sent an email as the CLA bot has requested but not yet received a reply. Though I have not seen it I expect it will be signed shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant