-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change C++ .h files into .hpp files for modernisation #610
base: develop
Are you sure you want to change the base?
Conversation
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added. |
f6063c0
to
29fef66
Compare
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added. |
29fef66
to
ebf78cd
Compare
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added. |
ebf78cd
to
db1dd72
Compare
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added. |
1 similar comment
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added. |
719fc9f
to
a569236
Compare
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added. |
a569236
to
6de026e
Compare
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added. |
6de026e
to
87f2507
Compare
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added. |
87f2507
to
1937183
Compare
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added. |
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @JustCallMeRay on file. In order for us to review and merge your code, please email [email protected] to get yourself added. |
I have sent an email as the CLA bot has requested but not yet received a reply. Though I have not seen it I expect it will be signed shortly. |
The generally accepted assumptions are:
Currently all the C++ headers are marked as C header files. This makes it a little more confusing for tooling and people to understand how the code is intended to be used.
The LLVM style guide does use .h files (though doesn't say to use them) but they have comment with
-*- C++ -*-
at the top of every .h file for tooling, since we don't have said comments, I recommend moving to .hpp files instead.More information is provided by Jason Turner