fix: compile on old cmake version and add PATH #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunwei37
requested review from
hp77-creator and
Officeyutong
and removed request for
hp77-creator
hp77-creator
approved these changes
Sep 5, 2024
| @@ -48,19 +48,19 @@ jobs: | |||
| run: | | |||
| make -C example -j | |||
| - name: Upload build results (without jit) | |||
| uses: actions/upload-artifact@v3 | |||
| uses: actions/upload-artifact@v4 | |||
There was a problem hiding this comment.
In master branch it is still v2, I saw the errors, is v4 in actions? I think jobs are not able to find this
There was a problem hiding this comment.
|
LGTM. |
Officeyutong
reviewed
Sep 6, 2024
| @@ -11,4 +11,3 @@ add_dependencies(bpftime_base_attach_impl spdlog::spdlog) | |||
|
|
|||
| target_link_libraries(bpftime_base_attach_impl INTERFACE spdlog::spdlog) | |||
|
|
|||
| set_property(TARGET bpftime_base_attach_impl PROPERTY CXX_STANDARD 20) | |||
yunwei37
added a commit
that referenced
this pull request
Sep 30, 2024
* fix link dl and cmake vesion * add dev container * docs: include PATH in the README * bump upload to v4 * fix hidden files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description