Update EIP-7642: don't remove NewBlock(Hashes) #9133
+4
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
File
|
This was referenced Dec 13, 2024
Marchhill
reviewed
Dec 18, 2024
|
|
||
| - Removing the `NewBlock` message. | ||
| Additionally we propose to remove the field that was deprecated by the merge, namely | ||
| the `TD` field in the `Status` message. |
There was a problem hiding this comment.
Could make consistent with capitalisation of td / TD
|
Is it important to maintain compatibility with other chains here? Couldn't they update to match mainnet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
NewBlockandNewBlockHashesare removed from the protocol, it makes it incompatible with other blockchains that haven't gone through The Merge, such as Polygon. For Ethereum, formally removingNewBlock(Hashes) is unnecessary since those are not sent anyway after The Merge (as stipulated by EIP-3675).