Interarrival as throttle #186
Conversation
NelsonVides
force-pushed
the
interarrival_as_throttle
branch
from
a5f279b to
42d65c5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 75.83% 77.20% +1.37%
==========================================
Files 32 32
Lines 1200 1167 -33
==========================================
- Hits 910 901 -9
+ Misses 290 266 -24 ☔ View full report in Codecov by Sentry. |
NelsonVides
force-pushed
the
throttle_api
branch
2 times, most recently
from
c16c3d6 to
2ae0719
Compare
NelsonVides
force-pushed
the
throttle_api
branch
16 times, most recently
from
73f1e61 to
92ef315
Compare
This also very importantly removes timers and loops from the critical controller process.
NelsonVides
force-pushed
the
interarrival_as_throttle
branch
from
58f94c0 to
416b25e
Compare
NelsonVides
force-pushed
the
interarrival_as_throttle
branch
from
416b25e to
8886183
Compare
| @@ -25,7 +25,7 @@ do(Scenario, Count, Settings) -> | |||
| case {amoc_controller:start_scenario(Scenario, Settings), Count} of | |||
| {ok, 0} -> ok; | |||
| {ok, Count} -> amoc_controller:add_users(1, Count); | |||
| Error -> Error | |||
| {Error, _} -> Error | |||
There was a problem hiding this comment.
why? according to the spec it was correct before the change:
-spec start_scenario(amoc:scenario(), amoc_config:settings()) ->
ok | {error, term()}.
There was a problem hiding this comment.
Error was {{error, Reason}, Count}, which is not the spec. Here we want to return the error that amoc_controller:start_scenario/2 returned.
| @@ -143,19 +143,13 @@ maybe_stop_timer(#state{tref = undefined}) -> | |||
| ok; | |||
| maybe_stop_timer(#state{tref = TRef}) -> | |||
| {ok, cancel} = timer:cancel(TRef), | |||
| consume_all_timer_ticks(delay_between_executions). | |||
| amoc_throttle_controller:consume_all_messages(delay_between_executions). | |||
There was a problem hiding this comment.
revert this change, it introduces erronous impression that we do here something with amoc_throttle_controller process.
There was a problem hiding this comment.
So where would you put it? The code was duplicated, wanted to put it in some common helper.
No description provided.