Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translator): extension server should fail close #4936

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

liorokman
Copy link
Contributor

This PR changes the default behavior for extension servers to fail-close instead of fail open.

Which issue(s) this PR fixes:
Fixes #4155

Release Notes: Yes

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 61.26126% with 43 lines in your changes missing coverage. Please review.

Project coverage is 66.35%. Comparing base (469de2f) to head (2357622).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/extension/registry/extension_manager.go 0.00% 16 Missing ⚠️
internal/xds/translator/translator.go 81.01% 10 Missing and 5 partials ⚠️
internal/xds/translator/extension.go 25.00% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4936      +/-   ##
==========================================
+ Coverage   66.27%   66.35%   +0.08%     
==========================================
  Files         209      209              
  Lines       32035    32124      +89     
==========================================
+ Hits        21231    21316      +85     
- Misses       9541     9543       +2     
- Partials     1263     1265       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liorokman
Copy link
Contributor Author

/retest

1 similar comment
@liorokman
Copy link
Contributor Author

/retest

@liorokman liorokman marked this pull request as ready for review December 18, 2024 12:35
@liorokman liorokman requested a review from a team as a code owner December 18, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Fail Safe" control knob for Extension Server
1 participant