Fixed Bug 59396 for Camel/Compliant casing. #59545
Open
+154
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shethaadit
requested review from
BrennanConroy,
halter73 and
captainsafia
as code owners
dotnet-issue-labeler
bot
added
the
area-networking
dotnet-policy-service
bot
added
the
community-contribution
captainsafia
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Thanks for opening this PR!
We'll need to add tests in ProblemDetailsDefaultWriterTest.cs and resolve the build error.
captainsafia
added
the
pr: pending author input
added 2 commits
December 18, 2024 19:54
captainsafia
requested changes
Dec 19, 2024
| @@ -503,6 +504,10 @@ public async Task WriteAsync_AddExtensions_WithJsonContext() | |||
| var options = new JsonOptions(); | |||
| options.SerializerOptions.TypeInfoResolver = JsonTypeInfoResolver.Combine(CustomProblemDetailsContext.Default, ProblemDetailsJsonContext.Default); | |||
|
|
|||
| var mockNamingPolicy = new Mock<JsonNamingPolicy>(); | |||
There was a problem hiding this comment.
Instead of modifying the existing tests, can we add a new one?
There was a problem hiding this comment.
Hi @captainsafia, My local is somehow not working properly and studio is not giving errors. I may need to reinstall devbox.
Since I am traveling somewhere for few days, I would really appreciate if you can help adding dependencies as they are only missing. That can complete the PR and issue. Please let me know. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Bug 59396 for Camel/Compliant casing.
Description
Fixed Bug 59396 for Camel/Compliant casing.
Fixes #59396