Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2732
Previously the default for
<Nullable>
in the repo was not specified (thus making itdisable
). This meant that each time we added a new project we needed to remember to add<Nullable>enable</Nullable>
to it, even though that really should be the default.This PR inverts the default, setting
<Nullable>enable</Nullable>
at the root in D.B.props, removing the same from any existing projects that have it and adding<Nullable>disable</Nullable>
to any projects that require code changes.I intentionally did not make any code changes here to keep this PR clean (since it already touched a lot of files) even though some projects likely required minimal changes to support nullable types.
Note that I intentionally did not try to use deeper D.B.props files even when all or most of the projects within a subfolder needed nullable types disabled. This will make it easier for us to know how many projects are left and keep the changes isolated to one project at a time as we go through and do it.
I also dropped a few
<LangVersion>latest</LangVersion>
that snuck in via #2737 since that was in flight already when I did #2736