Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert nullable default #2739

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

tlmii
Copy link
Member

@tlmii tlmii commented May 9, 2024

Related to #2732

Previously the default for <Nullable> in the repo was not specified (thus making it disable). This meant that each time we added a new project we needed to remember to add <Nullable>enable</Nullable> to it, even though that really should be the default.

This PR inverts the default, setting <Nullable>enable</Nullable> at the root in D.B.props, removing the same from any existing projects that have it and adding <Nullable>disable</Nullable> to any projects that require code changes.

I intentionally did not make any code changes here to keep this PR clean (since it already touched a lot of files) even though some projects likely required minimal changes to support nullable types.

Note that I intentionally did not try to use deeper D.B.props files even when all or most of the projects within a subfolder needed nullable types disabled. This will make it easier for us to know how many projects are left and keep the changes isolated to one project at a time as we go through and do it.

I also dropped a few <LangVersion>latest</LangVersion> that snuck in via #2737 since that was in flight already when I did #2736

@tlmii tlmii requested a review from deepchoudhery May 9, 2024 17:13
Copy link
Member

@deepchoudhery deepchoudhery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, LGTM!

@tlmii tlmii merged commit a159212 into main May 10, 2024
8 checks passed
@tlmii tlmii deleted the dev/timulhol/invert-nullability-default branch May 10, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants