fix: improve brotliDecompress: Uncaught (in promise) ReferenceError: callback is not defined #27358
+12
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Uncaught (in promise) ReferenceError: callback is not defined
Test program that should then pass:
It now matches the signature in https://nodejs.org/api/zlib.html#zlibbrotlidecompressbuffer-options-callback
The implementation is still incomplete, because the options are ignored. But it should still get it closer to the reference implementation (Node.js).