Escape works as "go back" in settings

[maxphilippov]

Did this as a test, cause it seemed like an easy refactor. And it was

Works, Notifications do look kinda weird.

There's an explicit "close settings" call when we click on "Add Second Device". @r10s @nicodh Should that remain or no? Here's a video of how it works

20241011_014510.mp4

Depends on #4006 so I'm not asking for review right now, too many changes displayed here

[r10s]

works nicely! also the stacking is much more what one would expect.

the PR needs a rebase or so, cannot say anything to the code by the thousands of changed lines :)

There's an explicit "close settings" call when we click on "Add Second Device". @r10s @nicodh Should that remain or no? Here's a video of how it works

if possible, it would nice if cancelling the initial "Add Second Device" alert is also shown atop of the settings dialog and canceling it just gets you back to settings. this would back trying out things and "clicking around, discovering what is possible" more predictable.

once the "Add Second Device" is started via "Continue", however, the settings dialog should disapepar so that one is full into the context of the "Add Second Device".

but that is no biggie - if it is hard to do, it is also fine as it is now.

[r10s]

as i was asked: for the "X" button, indeed it would be a bit weird if it closes all dialogs if they are visually stacked. this is not what is done usually in this case.

so either:

• for the stacking, the "back" button is superfluous, remove it and use only "X"
• do not stack visually, let "back" button close one level, "X" the whole dialog. "Escape" acts as the "back" button

i would go with the second option, to not add additional noise to UI, also it is what user already learned in Delta Chat :)

[nicodh]

Looks good to me.

Maybe the remaining focus border after closing a child dialog with ESC key could also be removed?

[nicodh]

Works, Notifications do look kinda weird.

what do you mean?

[maxphilippov]

Works, Notifications do look kinda weird.

what do you mean?

Just not used to it I guess, the fact that I see Settings in the background and Notifications are much smaller. Nothing wrong with dialog contents

[maxphilippov]

if possible, it would nice if cancelling the initial "Add Second Device" alert is also shown atop of the settings dialog and canceling it just gets you back to settings.

Rebased, added that. But it doesn't close when we press Continue, doesn't bother me, if it's not critical I'd merge. I'm looking into the whole "close everything in stack when we confirm some action" question as part of #2268

[Simon-Laux]

similar issue exists on pressing escape when making a new profile, there it should never close the dialog completely

[Simon-Laux]

as i was asked: for the "X" button, indeed it would be a bit weird if it closes all dialogs if they are visually stacked. this is not what is done usually in this case.

so either:

• for the stacking, the "back" button is superfluous, remove it and use only "X"
• do not stack visually, let "back" button close one level, "X" the whole dialog. "Escape" acts as the "back" button

i would go with the second option, to not add additional noise to UI, also it is what user already learned in Delta Chat :)

I would like to have this question from r10s addressed before we merge it. I would personally also prefer the second option.

[WofWca]

To note, this pattern is also used in ViewGroup:

deltachat-desktop/packages/frontend/src/components/dialogs/ViewGroup.tsx

Lines 284 to 290 in a5c0243

	{profileContact && (
	<ViewProfile
	onBack={() => setProfileContact(null)}
	onClose={onClose}
	contact={profileContact}
	/>
	)}

[maxphilippov]

as i was asked: for the "X" button, indeed it would be a bit weird if it closes all dialogs if they are visually stacked. this is not what is done usually in this case.
so either:

• for the stacking, the "back" button is superfluous, remove it and use only "X"
• do not stack visually, let "back" button close one level, "X" the whole dialog. "Escape" acts as the "back" button

i would go with the second option, to not add additional noise to UI, also it is what user already learned in Delta Chat :)

I would like to have this question from r10s addressed before we merge it. I would personally also prefer the second option.

I was going back-n-forth with this. I pushed an opacity version for now, gonna test it a bit and then ask for re-review