Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile to stop referencing defs from parent repo and use mys… #1499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −8
Open

Update Makefile to stop referencing defs from parent repo and use mys… #1499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions samples/confidential_ml/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
TOP = $(abspath ../..)
include $(TOP)/defs.mak

APPBUILDER = $(TOP)/scripts/appbuilder
APP_NAME = python3

APP_PATH = /usr/local/bin/python3
Expand All @@ -13,12 +9,12 @@ SHUTDOWN_WAIT = 2
all: $(PACKAGE)

appdir:
$(APPBUILDER) -m -d Dockerfile
@myst-appbuilder -m -d Dockerfile

$(PACKAGE): appdir package.pem
$(MYST) mkext2 appdir rootfs
$(MYST) fssig --roothash rootfs > roothash
$(MYST) package-sgx --roothash=roothash package.pem config.json
@myst mkext2 appdir rootfs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer having it without the @, that way we can see what commands were run in the pipeline logs. For end-user it is not a big difference in experience.

@myst fssig --roothash rootfs > roothash
@myst package-sgx --roothash=roothash package.pem config.json

server:
./$(PACKAGE) --rootfs=rootfs
Expand Down