Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add responsive styling for mobile compatibility #7298

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

liamsegura
Copy link

@liamsegura liamsegura commented Oct 3, 2024

Fixes #7241

Summary

Long time user of decap-cms, always wanted a way to use while on my phone, this PR fixes that.

Added media queries for responsive styling
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> is required in the html for it to work, i have only updated the dev-test html

If this is merged in I can go through the other repos and update that accordingly

I can improve this visually as there are areas id like to modify but that can be altered at a later date

Screen.Recording.2024-10-03.at.2.01.40.PM.mp4

Screenshot 2024-10-03 at 1 47 46 PM
Screenshot 2024-10-03 at 1 45 59 PM
Screenshot 2024-10-03 at 1 45 42 PM
Screenshot 2024-10-03 at 1 45 40 PM

Test plan

Checklist

Please add a x inside each checkbox:

A picture of a cute animal (not mandatory but encouraged)

Screenshot 2024-10-03 at 4 02 37 PM

@liamsegura liamsegura requested a review from a team as a code owner October 3, 2024 15:13
@martinjagodic martinjagodic requested review from martinjagodic and removed request for a team October 17, 2024 10:56
@martinjagodic
Copy link
Member

@liamsegura, thanks for your effort. While reviewing, I had some comments/ideas, and I figured it would be faster if I just implemented them. Then I got carried away and I did a lot of additional changes. I ran out of time to fix snapshots, so tests are failing.

If you have any comments, let me know. I used clamp a lot and Increased some font sizes because I think 8px is too little to read.

@liamsegura
Copy link
Author

liamsegura commented Nov 15, 2024

Hey @martinjagodic

Thank you. When I get some time ill take a look, as long as its working on smaller screens, then visually i'm happy for whatever you'd prefer.

The overall styling I implemented could have done with changes so very open to it, do we know how we will go about adding: <meta name="viewport" content="width=device-width, initial-scale=1.0" /> to production? is it just a case of going through repos within decaporg and adding this line? or is there something else I'm missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Add New Images from Mobile
2 participants