Pageverify #1006
Merged
Pageverify #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpomfret
commented
Aug 27, 2023
| @@ -274,3 +275,31 @@ Describe "Contained Database SQL Authenticated Users" -Tag ContainedDBSQLAuth, C | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@SQLDBAWithABeard - are you happy with this logic within the test?
There was a problem hiding this comment.
I am. A comment to explain it for future us and others might be useful also!!
There was a problem hiding this comment.
consider it done 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A New PR
THANK YOU - We love to get PR's and really appreciate your time and help to improve this module
Accepting a PR
Before we accept the PR - please confirm that you have run the tests locally to avoid our automated build and release process failing. You can see how to do that in our wiki
https://github.com/sqlcollaborative/dbachecks/wiki
Please confirm you have 0 failing Pester Tests
[] There are 0 failing Pester tests
Changes this PR brings
adding new check from #884 for v5 functionality