add react-dates dependency #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiberiuichim
approved these changes
Mar 1, 2023
tiberiuichim
approved these changes
Mar 27, 2023
|
I am ok with adding the dependency. I would add the same version we use in Volto though, for consistency. Or at least anything that won't get us a double react-dates dep in node_modules. Also, while we're here, maybe it's worth adding rc-time-picker if you have a few extra minutes to spare. |
avoinea
approved these changes
Jun 6, 2023
avoinea
requested changes
Jun 6, 2023
add missing comma
avoinea
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.