Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
A few days ago, when I was trying to use a monorepo, I encountered the problem that in your repo was already mentioned and documented as issue #20.
I found the idea of recursively searching node_modules/.bin directories a bit wild. Forty's idea of allowing a list of commands albeit quite sexy.
I took the liberty of sending you a PR that implements this function. It looks like a lot of code, but it's just a bunch of helper functions and the proper remodeling of the add-node-modules-path interactive function.
Additionally a short paragraph in the README.md as well as ert tests.
Of course, the implementation is backwards compatible; it is still possible to use the default value of add-node-modules-path-command or override it with a single command.
Due to the fact that with several commands some commands can work well, but others don't, I had to adjust the reporting. Directories that could be added to exec-path are reported using (message ...). Commands that failed are reported as warnings in the Warnings buffer.
Maybe you are interested in the extension. otherwise just ignore :)
best regards from austria,
Max