Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Binary format to store test aggregates #51

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

Swatinem
Copy link
Contributor

This defines a binary file format similar to the various cache formats we use in Symbolicator.

The format contains various aggregations for a configurable number of days.

@Swatinem Swatinem self-assigned this Nov 19, 2024
@Swatinem Swatinem force-pushed the swatinem/binary-rollup-format branch 2 times, most recently from 8432c94 to bad2ad5 Compare November 21, 2024 14:36
@Swatinem Swatinem force-pushed the swatinem/binary-rollup-format branch from 73bad3a to 5749cab Compare November 26, 2024 15:54
@Swatinem Swatinem force-pushed the swatinem/binary-rollup-format branch from 833ab8f to 24806c1 Compare November 29, 2024 13:51
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 97.65494% with 28 lines in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (c840502) to head (411e84a).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/binary/bindings.rs 90.65% 10 Missing ⚠️
src/binary/format.rs 94.01% 10 Missing ⚠️
src/binary/error.rs 0.00% 6 Missing ⚠️
src/binary/writer.rs 99.43% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   85.34%   93.59%   +8.24%     
==========================================
  Files           5       14       +9     
  Lines         587     1780    +1193     
==========================================
+ Hits          501     1666    +1165     
- Misses         86      114      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 97.65494% with 28 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/binary/bindings.rs 90.65% 10 Missing ⚠️
src/binary/format.rs 94.01% 10 Missing ⚠️
src/binary/error.rs 0.00% 6 Missing ⚠️
src/binary/writer.rs 99.43% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Swatinem Swatinem force-pushed the swatinem/binary-rollup-format branch from 24806c1 to 4282b18 Compare November 29, 2024 13:59
@Swatinem Swatinem marked this pull request as ready for review December 5, 2024 15:49
@Swatinem
Copy link
Contributor Author

Swatinem commented Dec 5, 2024

I believe this should be feature complete now.
I would appreciate a review, and would be happy to schedule another meeting to walk through the code or through the feedback / questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant