ref: Migrate to `isTeamPlan` GQ field #3592

RulaKhaled · 2024-12-18T21:46:39Z

Description

This PR aims to remove the isTeamPlan helper function in Gazebo in favor of the new GraphQL field for the same.

fyi we're gonna come back once available plans is refactored to pass down isTeamPlan instead of checking for plans enum for the selected plans, this is just a weird edge case.

Notable Changes

updated tests
removed helper
updated the plan

Screenshots

nothing visual changed

issue: #2998

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov-staging · 2024-12-18T21:49:15Z

Bundle Report

Changes will increase total bundle size by 3.38kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system-esm	6.05MB	1.86kB (0.03%) ⬆️
gazebo-staging-system	6.0MB	1.52kB (0.03%) ⬆️

codecov-notifications · 2024-12-18T21:50:08Z

❌ 14 Tests Failed:

Tests completed	Failed	Passed	Skipped
4167	14	4153	0

View the top 3 failed tests by shortest run time

src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx > CurrentOrgPlan > when owner has an account > renders AccountOrgs

Stack Traces | 1s run time

TestingLibraryElementError: Unable to find an element with the text: /AccountOrgs/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx:426:40

src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx > CurrentOrgPlan > when shouldRenderBillingDetails should be shown > when usesInvoice is true > renders BillingDetails

Stack Traces | 1s run time

TestingLibraryElementError: Unable to find an element with the text: /BillingDetails/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx:325:45

src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx > CurrentOrgPlan > when owner has an account > and less than 90% of seats are in use > does not render a usage banner

Stack Traces | 1s run time

TestingLibraryElementError: Unable to find an element with the text: /CurrentPlanCard/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx:387:46

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

codecov-qa · 2024-12-18T21:50:09Z

❌ 14 Tests Failed:

Tests completed	Failed	Passed	Skipped
4167	14	4153	0

View the top 3 failed tests by shortest run time

src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx > CurrentOrgPlan > when owner has an account > renders AccountOrgs

Stack Traces | 1s run time

TestingLibraryElementError: Unable to find an element with the text: /AccountOrgs/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx:426:40

src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx > CurrentOrgPlan > when shouldRenderBillingDetails should be shown > when usesInvoice is true > renders BillingDetails

Stack Traces | 1s run time

TestingLibraryElementError: Unable to find an element with the text: /BillingDetails/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx:325:45

src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx > CurrentOrgPlan > when owner has an account > and less than 90% of seats are in use > does not render a usage banner

Stack Traces | 1s run time

TestingLibraryElementError: Unable to find an element with the text: /CurrentPlanCard/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx:387:46

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

codecov-public-qa · 2024-12-18T21:50:14Z

❌ 14 Tests Failed:

Tests completed	Failed	Passed	Skipped
4167	14	4153	0

View the top 3 failed tests by shortest run time

src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx > CurrentOrgPlan > when owner has an account > renders AccountOrgs

Stack Traces | 1s run time

TestingLibraryElementError: Unable to find an element with the text: /AccountOrgs/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx:426:40

src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx > CurrentOrgPlan > when shouldRenderBillingDetails should be shown > when usesInvoice is true > renders BillingDetails

Stack Traces | 1s run time

TestingLibraryElementError: Unable to find an element with the text: /BillingDetails/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx:325:45

src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx > CurrentOrgPlan > when owner has an account > and less than 90% of seats are in use > does not render a usage banner

Stack Traces | 1s run time

TestingLibraryElementError: Unable to find an element with the text: /CurrentPlanCard/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx:387:46

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

codecov-releaser · 2024-12-18T21:52:54Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`dca781e`	Wed, 18 Dec 2024 21:52:53 GMT	Expired	Expired
`6ddc688`	Thu, 19 Dec 2024 19:57:05 GMT	Expired	Expired
`8e7a1a4`	Thu, 19 Dec 2024 22:20:56 GMT	Cloud	Enterprise

codecov · 2024-12-18T22:09:55Z

❌ 14 Tests Failed:

Tests completed	Failed	Passed	Skipped
4167	14	4153	0

View the top 3 failed tests by shortest run time

src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx > CurrentOrgPlan > when owner has an account > renders AccountOrgs

Stack Traces | 1s run time

TestingLibraryElementError: Unable to find an element with the text: /AccountOrgs/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx:426:40

src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx > CurrentOrgPlan > when shouldRenderBillingDetails should be shown > when usesInvoice is true > renders BillingDetails

Stack Traces | 1s run time

TestingLibraryElementError: Unable to find an element with the text: /BillingDetails/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx:325:45

src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx > CurrentOrgPlan > when owner has an account > and less than 90% of seats are in use > does not render a usage banner

Stack Traces | 1s run time

TestingLibraryElementError: Unable to find an element with the text: /CurrentPlanCard/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="w-full lg:w-4/5"
    />
  </div>
</body>
 ❯ waitForWrapper node_modules/@.../dom/dist/wait-for.js:163:27
 ❯ node_modules/@.../dom/dist/query-helpers.js:86:33
 ❯ .../subRoutes/CurrentOrgPlan/CurrentOrgPlan.test.tsx:387:46

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

codecov · 2024-12-18T23:44:10Z

Bundle Report

Changes will increase total bundle size by 3.38kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	6.0MB	1.52kB (0.03%) ⬆️
gazebo-production-system-esm	6.05MB	1.86kB (0.03%) ⬆️

ajay-sentry · 2024-12-19T22:01:07Z

src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/UpdateBlurb/UpdateBlurb.tsx

@@ -48,7 +49,7 @@ const UpdateBlurb = ({
      {diffSeats && (
        <li className="pl-2">{`You are changing seats from ${currentPlan?.planUserCount} to [${seats}]`}</li>
      )}
-      {diffBillingType && (
+      {diffBillingType && !currentIsFree && (


weird this is showing up, I thought I had committed it already

RulaKhaled marked this pull request as ready for review December 18, 2024 21:46

RulaKhaled added 3 commits December 19, 2024 19:57

update with isTeamPlan

2357074

Wrap up all tests

9df7764

resolve conflicts

6ddc688

RulaKhaled force-pushed the update-isTeamPlan branch from dca781e to 6ddc688 Compare December 19, 2024 19:50

ajay-sentry reviewed Dec 19, 2024

View reviewed changes

ajay-sentry approved these changes Dec 19, 2024

View reviewed changes

fix tests

8e7a1a4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref: Migrate to `isTeamPlan` GQ field #3592

ref: Migrate to `isTeamPlan` GQ field #3592

RulaKhaled commented Dec 18, 2024 •

edited

Loading

codecov-staging bot commented Dec 18, 2024 •

edited

Loading

codecov-notifications bot commented Dec 18, 2024 •

edited by codecov-staging bot

Loading

codecov-qa bot commented Dec 18, 2024 •

edited

Loading

codecov-public-qa bot commented Dec 18, 2024 •

edited

Loading

codecov-releaser commented Dec 18, 2024 •

edited

Loading

codecov bot commented Dec 18, 2024 •

edited

Loading

codecov bot commented Dec 18, 2024 •

edited

Loading

ajay-sentry Dec 19, 2024

ref: Migrate to isTeamPlan GQ field #3592

Are you sure you want to change the base?

ref: Migrate to isTeamPlan GQ field #3592

Conversation

RulaKhaled commented Dec 18, 2024 • edited Loading

Description

Notable Changes

Screenshots

Legal Boilerplate

codecov-staging bot commented Dec 18, 2024 • edited Loading

Bundle Report

codecov-notifications bot commented Dec 18, 2024 • edited by codecov-staging bot Loading

❌ 14 Tests Failed:

codecov-qa bot commented Dec 18, 2024 • edited Loading

❌ 14 Tests Failed:

codecov-public-qa bot commented Dec 18, 2024 • edited Loading

❌ 14 Tests Failed:

codecov-releaser commented Dec 18, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

codecov bot commented Dec 18, 2024 • edited Loading

❌ 14 Tests Failed:

codecov bot commented Dec 18, 2024 • edited Loading

Bundle Report

ajay-sentry Dec 19, 2024

Choose a reason for hiding this comment

ref: Migrate to `isTeamPlan` GQ field #3592

ref: Migrate to `isTeamPlan` GQ field #3592

RulaKhaled commented Dec 18, 2024 •

edited

Loading

codecov-staging bot commented Dec 18, 2024 •

edited

Loading

codecov-notifications bot commented Dec 18, 2024 •

edited by codecov-staging bot

Loading

codecov-qa bot commented Dec 18, 2024 •

edited

Loading

codecov-public-qa bot commented Dec 18, 2024 •

edited

Loading

codecov-releaser commented Dec 18, 2024 •

edited

Loading

codecov bot commented Dec 18, 2024 •

edited

Loading

codecov bot commented Dec 18, 2024 •

edited

Loading