-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 2017 GSoC report activity yaml #658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please amend your commit message. You should not put everything on one line (commit head).
_reports/macbox7.md
Outdated
@@ -44,392 +44,392 @@ social: | |||
email: [email protected] | |||
blog: https://macbox7.github.io/Blog-GSOC18/ | |||
activity: | |||
- 0: | |||
- 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your commit message does not reflect your changes. This file is not 2017 report but 2018.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also your commit message should follow the commit guidelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Codewise, it LGTM though your commit message is not according to our guidelines. It is too long which is not preferred. I would suggest to make it according to the length mentioned in https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html . The main commit message should just include the important details and the rest of the things can be included in the commit description.
Also, you might want to make changes into other branches since they would prevent your master branch from messing up and also allow you to do multiple issues/PR at the same time.
This fixes the previously 0 based yaml and changes it to 1 based. Fixes #616
This fixes the previously 0 based yaml and changes it to 1 based.
Fixes #616
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>
to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!