Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly expose WorkflowEntrypoint constructor in TS types #3239

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: properly expose WorkflowEntrypoint constructor in TS types #3239

wants to merge 2 commits into from
+12 −0

Conversation

LuisDuarte1
Copy link
Contributor

@LuisDuarte1 LuisDuarte1 commented Dec 13, 2024 •
edited
Loading

Previously we didn't export the constructor for WorkflowEntrypoint in TS types (we always had one in the workerd implementation itself) even though other classes like DurableObject or WorkerEntrypoint also do it. This makes constructor types in WorkflowEntrypoint on par with those two.

@LuisDuarte1 LuisDuarte1 requested review from a team as code owners December 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penalosa penalosa penalosa approved these changes

@jasnell jasnell jasnell approved these changes

@celso celso celso approved these changes

@ketanhwr ketanhwr Awaiting requested review from ketanhwr ketanhwr is a code owner automatically assigned from cloudflare/workers-runtime-1

@vickykont vickykont Awaiting requested review from vickykont vickykont is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LuisDuarte1 @celso @jasnell @penalosa