Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) Fix typo #3593

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

(doc) Fix typo #3593

wants to merge 1 commit into from

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Dec 18, 2024

combintation -> combination

Description Of Changes

Fixed a typo that was noticed while reviewing other code.

Motivation and Context

Once seen, it cannot be unseen, and must be fixed.

Testing

N/A

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A

@gep13 gep13 requested a review from pauby December 18, 2024 10:13
@gep13
Copy link
Member Author

gep13 commented Dec 18, 2024

@pauby if you are happy with this change, we should assign this PR to the next milestone for CLI, and get this merged in.

@pauby pauby added this to the vNext milestone Dec 18, 2024
@pauby
Copy link
Member

pauby commented Dec 18, 2024

@gep13 I have approved this and assigned it to vNext milestone. I'm assuming we'll merge it in at that time rather than now.

@gep13
Copy link
Member Author

gep13 commented Dec 18, 2024

@pauby said...
I'm assuming we'll merge it in at that time rather than now.

vNext will go out from what is contained within the develop branch, so there is nothing to prevent this being merged in now. We just need to remember to switch the milestone for this PR, once we know what vNext is going to be.

combintation -> combination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants