Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CIRCLECI environments to return level 3 color support #157

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Update CIRCLECI environments to return level 3 color support #157

merged 2 commits into from
Dec 18, 2024

Conversation

bjohnso5
Copy link
Contributor

No description provided.

@bjohnso5
Copy link
Contributor Author

it seems there are existing test failures on main, unrelated to this PR

@bjohnso5
Copy link
Contributor Author

bjohnso5 commented Dec 17, 2024 •
edited
Loading

Having had a quick look at the failing tests, it appears the defaulting precedence may have been changed without the tests being updated - if FORCE_COLOR is true in the environment, rather than being set to a level, level 1 is always returned early. This skips most of the other flag parsing logic, like support for overriding to 256 color, or TTY detection.

@sindresorhus sindresorhus merged commit 89a52f4 into chalk:main Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaki-arain zaki-arain zaki-arain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjohnso5 @zaki-arain @sindresorhus