-
Notifications
You must be signed in to change notification settings - Fork 191
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: typo in cmakeListsPath for turbo native modules (#629)
<!-- Please provide enough information so that others can review your pull request. --> <!-- Keep pull requests small and focused on a single change. --> ### Summary <!-- What existing problem does the pull request solve? Can you solve the issue with a different approach? --> It fixes #627, as we were having the same issue in our react native project. When opting in Turbo Native Modules or Fabric Views, `cmakeListPath` in generated `react-native.config.js` was not consistent with the hierarchy generated by CodeGen. This fix corrects the path as stated by document. If my fix isn't correct, feel free to correct me. Thank you. ### Test plan <!-- List the steps with which we can test this change. Provide screenshots if this changes anything visual. --> - Select 'Turbo module - requires new arch (experimental)' to create Turbo native module and include it into the project - Build for android with `npx react-native run-android` to validate the fix was correct. --------- Co-authored-by: withSang <[email protected]> Co-authored-by: Burak Güner <[email protected]>
- Loading branch information
1 parent
639f545
commit de254c6
Showing
4 changed files
with
16 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters