Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset email: change branding to Beeper logo #32

Open
wants to merge 26 commits into
base: beeper
Choose a base branch
from

Conversation

sumnerevans
Copy link
Member

Pull Request Checklist

Signed-off-by: Sumner Evans [email protected]

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

{% else %}
<img src="https://matrix.org/img/matrix-120x51.png" width="120" height="51" alt="[matrix]"/>
{% endif %}
<img src="https://beeper.github.io/static/brand/email-header.20240320.2056.png" width="256" height="56" alt="[Beeper]"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a higher res version of this? on retina displays this will show up pixelated/1x

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get one, but we also use this image when sending rageshake emails via the chatwoot API, and we can't include HTML there so we have to control the size of the image by the literal resolution of the image.

I would have to go look and remember how I even got these assets in the first place and then get an upscaled version for this, and then use it when we have the ability to specify HTML.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i think the simple fix here is to always use a 2x version and specify the width/height = 1/2 of 2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants